Рефакторинг

server/config/base.js

@@ -18,13 +18,13 @@ module.exports = {
 
     servers: [
         {
-            name: '1',
-            mode: 'normal', //none, normal, site, reader, omnireader
+            serverName: '1',
+            mode: 'normal',
             ip: '127.0.0.1',
             port: '33080',
         },
         {
-            name: '2',
+            serverName: '2',
             mode: 'omnireader',
             ip: '0.0.0.0',
             port: '33081',

server/index.js

@@ -19,10 +19,10 @@ async function main() {
     for (let server of config.servers) {
         if (server.mode !== 'none') {
             const app = express();
-            app.serverConfig = server;
+            const serverConfig = Object.assign({}, config, server);
 
             let devModule = undefined;
-            if (config.branch == 'development') {
+            if (serverConfig.branch == 'development') {
                 const devFileName = './dev.js'; //ignored by pkg -50Mb executable size
                 devModule = require(devFileName);
                 devModule.webpackDevMiddleware(app);
@@ -32,9 +32,9 @@ async function main() {
             app.use(express.json());
             if (devModule)
                 devModule.logQueries(app);
-            app.use(express.static(config.publicDir, { maxAge: '30d' }));
+            app.use(express.static(serverConfig.publicDir, { maxAge: '30d' }));
 
-            require('./routes').initRoutes(app, connPool, config);
+            require('./routes').initRoutes(app, connPool, serverConfig);
 
             if (devModule) {
                 devModule.logErrors(app);
@@ -45,8 +45,8 @@ async function main() {
                 });
             }
 
-            app.listen(server.port, server.ip, function() {
-                log(`Server-${server.name} is ready on ${server.ip}:${server.port}, mode: ${server.mode}`);
+            app.listen(serverConfig.port, serverConfig.ip, function() {
+                log(`Server-${serverConfig.serverName} is ready on ${serverConfig.ip}:${serverConfig.port}, mode: ${serverConfig.mode}`);
             });
         }
     }

server/routes.js

@@ -4,9 +4,8 @@ function initRoutes(app, connPool, config) {
     const misc = new c.MiscController(connPool, config);
 
     //access
-    const serverMode = app.serverConfig.mode;
     const [all, normal, site, reader, omnireader] = // eslint-disable-line no-unused-vars
-        [serverMode, 'normal', 'site', 'reader', 'omnireader'];
+        [config.mode, 'normal', 'site', 'reader', 'omnireader'];
 
     //routes
     const routes = [
@@ -19,7 +18,7 @@ function initRoutes(app, connPool, config) {
         access = new Set(access);
 
         let callback = () => {};
-        if (access.has(serverMode)) {//allowed
+        if (access.has(config.mode)) {//allowed
             callback = async function(req, res) {
                 try {
                     const result = await controller(req, res, options);